Split withEnv only on first = character
#468
Conversation
|
Fix looks ok, but can you provide a test? |
nre-ableton
changed the title
= character
There was a problem hiding this comment.
Looks good! One final small task -- can you please squash together 4cb0d4a and ed41bc8 to a single commit? Also, please remove the link to the issue in the commit message -- the message should just say what is being fixed. Should this repository migrate from GitHub to somewhere else in the future, then the log should still make sense. Thanks!
(Also, I'm happy to do this for you if you'd like, just edit your PR to allow edits from maintainers. See https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork).
|
Thank you for the review and feedback. I squashed the commits. |
This fixes #388 by spliting the
withEnvlist item only for the first equals sign.